feat: add Multiscale/proj/spatial conventions support#64
feat: add Multiscale/proj/spatial conventions support#64vincentsarago wants to merge 4 commits intomainfrom
Conversation
| ) | ||
|
|
||
| def _get_groups(self) -> List[str]: | ||
| def _get_groups(self) -> list[str]: |
There was a problem hiding this comment.
We only keep Groups with GeoZarr conventions (spatial + proj)
| dataset = tree.to_dataset() | ||
| transform = dataset.rio.transform() | ||
|
|
||
| bbox = array_bounds(width, height, transform) # type: ignore |
There was a problem hiding this comment.
Because the conventions is super open we need to check in multiple places where to find either the bbox/shape/transform
| f"Cannot determine MaxZoom for group {group}.", | ||
| UserWarning, | ||
| stacklevel=2, | ||
| ) |
There was a problem hiding this comment.
lot of duplication between both get_minzoom/get_maxzoom. We should refactor
|
TODO:
|
|
must close https://github.com/EOPF-Explorer/coordination/issues/199 first |
|
let's have a look at xarray-contrib/rasterix#68 to make sure we didn't miss anything |
|
Don't we use rioxarray on our side? I hope my PR supporting zarr convetions should be merged soon: corteva/rioxarray#905 |
|
@emmanuelmathot we do but I just want to make sure that we do the same as they are doing and that we are not missing anything in our analysis of the spec |
This PR updates the
Readerto use (Geo) Zarr conventionscloses #53